Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} disable artifact streaming #6971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

{AKS} disable artifact streaming #6971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ To release a new version, please select a new version number (usually plus 1 to

Pending
+++++++
* Add `--disable-artifact-streaming` in `az aks nodepool add` and `az aks nodepool update` commands.

0.5.171
+++++++
Expand Down
6 changes: 6 additions & 0 deletions src/aks-preview/azext_aks_preview/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1680,6 +1680,9 @@
- name: --enable-artifact-streaming
type: bool
short-summary: Enable artifact streaming for VirtualMachineScaleSets managed by a node pool, to speed up the cold-start of containers on a node through on-demand image loading. To use this feature, container images must also enable artifact streaming on ACR. If not specified, the default is false.
- name: --disable-artifact-streaming
type: bool
short-summary: Disable artifact streaming for VirtualMachineScaleSets managed by a node pool.
examples:
- name: Create a nodepool in an existing AKS cluster with ephemeral os enabled.
text: az aks nodepool add -g MyResourceGroup -n nodepool1 --cluster-name MyManagedCluster --node-osdisk-type Ephemeral --node-osdisk-size 48
Expand Down Expand Up @@ -1795,6 +1798,9 @@
- name: --enable-artifact-streaming
type: bool
short-summary: Enable artifact streaming for VirtualMachineScaleSets managed by a node pool, to speed up the cold-start of containers on a node through on-demand image loading. To use this feature, container images must also enable artifact streaming on ACR. If not specified, the default is false.
- name: --disable-artifact-streaming
type: bool
short-summary: Disable artifact streaming for VirtualMachineScaleSets managed by a node pool.
- name: --os-sku
type: string
short-summary: The os-sku of the agent node pool.
Expand Down
2 changes: 2 additions & 0 deletions src/aks-preview/azext_aks_preview/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,7 @@ def load_arguments(self, _):
c.argument('allowed_host_ports', validator=validate_allowed_host_ports, is_preview=True)
c.argument('asg_ids', validator=validate_application_security_groups, is_preview=True)
c.argument('enable_artifact_streaming', action='store_true', validator=validate_artifact_streaming, is_preview=True)
c.argument('disable_artifact_streaming', action='store_true', validator=validate_artifact_streaming, is_preview=True)
c.argument('node_public_ip_tags', arg_type=tags_type, validator=validate_node_public_ip_tags,
help='space-separated tags: key[=value] [key[=value] ...].')

Expand All @@ -755,6 +756,7 @@ def load_arguments(self, _):
c.argument('allowed_host_ports', validator=validate_allowed_host_ports, is_preview=True)
c.argument('asg_ids', validator=validate_application_security_groups, is_preview=True)
c.argument('enable_artifact_streaming', action='store_true', validator=validate_artifact_streaming, is_preview=True)
c.argument('disable_artifact_streaming', action='store_true', validator=validate_artifact_streaming, is_preview=True)
c.argument('os_sku', arg_type=get_enum_type(node_os_skus_update), validator=validate_os_sku)

with self.argument_context('aks nodepool upgrade') as c:
Expand Down