Update ProviderHub CLI Support for Comma Separated Values #8461
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1463,7 +1463,9 @@ def _execute_operations(self): | |||||||||
|
|
||||||||||
| @register_callback | ||||||||||
| def pre_operations(self): | ||||||||||
| from azure.cli.core.aaz import AAZArgEnum | ||||||||||
| args = str(self.ctx.args).split(",") | ||||||||||
| return AAZArgEnum(args) | ||||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||||
|
|
||||||||||
| @register_callback | ||||||||||
| def post_operations(self): | ||||||||||
|
|
||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,8 +6,9 @@ interactions: | |
| "Resource Provider Service as a Service", "incidentRoutingTeam": "RPaaS", "manifestOwners": | ||
| ["SPARTA-PlatformServiceAdministrator"], "serviceTreeInfos": [{"componentId": | ||
| "d1b7d8ba-05e2-48e6-90d6-d781b99c6e69", "serviceId": "d1b7d8ba-05e2-48e6-90d6-d781b99c6e69"}]}, | ||
| "metadata": {"BypassManifestValidation": true}, "providerType": "Hidden, Internal", | ||
| "providerVersion": "2.0", "tokenAuthConfiguration": {"authenticationScheme": | ||
| "PoP", "signedRequestScope": "ResourceUri"}}}' | ||
| headers: | ||
| Accept: | ||
| - application/json | ||
|
|
@@ -18,31 +19,31 @@ interactions: | |
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '720' | ||
| Content-Type: | ||
| - application/json | ||
| ParameterSetName: | ||
| - --token-auth-configuration --service-tree-infos --capabilities --capabilities | ||
| --manifest-owners --incident-contact-email --incident-routing-service --incident-routing-team | ||
| --provider-version --provider-type --provider-namespace --metadata | ||
| User-Agent: | ||
| - AZURECLI/2.67.0 azsdk-python-core/1.31.0 Python/3.12.0 (Windows-11-10.0.26100-SP0) | ||
| method: PUT | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ProviderHub/providerRegistrations/Private.VPTest?api-version=2024-04-01-preview | ||
| response: | ||
| body: | ||
| string: '{"properties":{"privateResourceProviderConfiguration":{"allowedSubscriptions":["81ddc363-4b54-4223-833d-16b2a424d8a0"]},"provisioningState":"Succeeded","namespace":"Private.VPTest","providerVersion":"2.0","providerType":"Internal, | ||
| Hidden","management":{"manifestOwners":["SPARTA-PlatformServiceAdministrator"],"incidentRoutingService":"Resource | ||
| Provider Service as a Service","incidentRoutingTeam":"RPaaS","incidentContactEmail":"[email protected]","serviceTreeInfos":[{"serviceId":"d1b7d8ba-05e2-48e6-90d6-d781b99c6e69","componentId":"d1b7d8ba-05e2-48e6-90d6-d781b99c6e69"}]},"capabilities":[{"quotaId":"CSP_2015-05-01","effect":"Allow"},{"quotaId":"CSP_MG_2017-12-01","effect":"Allow"}],"metadata":{"BypassManifestValidation":true},"tokenAuthConfiguration":{"authenticationScheme":"PoP","signedRequestScope":"ResourceUri","disableCertificateAuthenticationFallback":false}},"id":"/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ProviderHub/providerRegistrations/Private.VPTest","type":"Microsoft.ProviderHub/providerRegistrations","name":"Private.VPTest","kind":"Managed","systemData":{"createdBy":"[email protected]","createdByType":"User","createdAt":"2022-11-16T00:05:06.5154703Z","lastModifiedBy":"nataliezoz@microsoft.com","lastModifiedByType":"User","lastModifiedAt":"2025-02-07T22:45:57.4420139Z"}}' | ||
| headers: | ||
| cache-control: | ||
| - no-cache | ||
| content-length: | ||
| - '1344' | ||
| content-type: | ||
| - application/json; charset=utf-8 | ||
| date: | ||
| - Fri, 07 Feb 2025 22:45:57 GMT | ||
| expires: | ||
| - '-1' | ||
| pragma: | ||
|
|
@@ -53,12 +54,12 @@ interactions: | |
| - CONFIG_NOCACHE | ||
| x-content-type-options: | ||
| - nosniff | ||
| x-ms-ratelimit-remaining-subscription-global-writes: | ||
| - '11999' | ||
| x-ms-ratelimit-remaining-subscription-writes: | ||
| - '799' | ||
| x-msedge-ref: | ||
| - 'Ref A: D03FDA3C0F81495192B17B735EB0F8C1 Ref B: CO6AA3150218019 Ref C: 2025-02-07T22:45:57Z' | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| interactions: | ||
| - request: | ||
| body: '{"kind": "Managed", "properties": {"endpoints": [{"apiVersions": ["2019-01-01"], | ||
| "locations": ["WestUS"]}], "regionality": "Regional", "routingType": "ProxyOnly, | ||
| Extension"}}' | ||
| headers: | ||
| Accept: | ||
| - application/json | ||
|
|
@@ -12,27 +13,28 @@ interactions: | |
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '174' | ||
| Content-Type: | ||
| - application/json | ||
| ParameterSetName: | ||
| - --endpoints --regionality --provider-namespace --resource-type --routing-type | ||
| User-Agent: | ||
| - AZURECLI/2.67.0 azsdk-python-core/1.31.0 Python/3.12.0 (Windows-11-10.0.26100-SP0) | ||
| method: PUT | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ProviderHub/providerRegistrations/Private.VPTest/resourcetypeRegistrations/extensionresourcetype?api-version=2024-04-01-preview | ||
| response: | ||
| body: | ||
| string: '{"properties":{"name":"extensionresourcetype","routingType":"ProxyOnly, | ||
| Extension","regionality":"Regional","endpoints":[{"kind":"Managed","apiVersions":["2019-01-01"],"locations":["WestUS"]}],"defaultApiVersion":"2019-01-01","throttlingRules":[{"action":"Private.VPTest/extensionresourcetype/write","metrics":[{"type":"NumberOfRequests","limit":400,"interval":"PT1H"}]},{"action":"Private.VPTest/extensionresourcetype/read","metrics":[{"type":"NumberOfRequests","limit":4000,"interval":"PT1H"}]},{"action":"Private.VPTest/extensionresourcetype/delete","metrics":[{"type":"NumberOfRequests","limit":5000,"interval":"PT1H"}]}],"enableAsyncOperation":false,"provisioningState":"Succeeded","enableThirdPartyS2S":false,"templateDeploymentOptions":{"preflightSupported":true,"preflightOptions":["DefaultValidationOnly"]}},"id":"/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ProviderHub/providerRegistrations/Private.VPTest/resourceTypeRegistrations/extensionresourcetype","type":"Microsoft.ProviderHub/providerRegistrations/resourceTypeRegistrations","name":"extensionresourcetype","kind":"Managed","systemData":{"createdBy":"[email protected]","createdByType":"User","createdAt":"2025-02-07T22:56:55.0029838Z","lastModifiedBy":"[email protected]","lastModifiedByType":"User","lastModifiedAt":"2025-02-07T22:56:55.0029838Z"}}' | ||
| headers: | ||
| cache-control: | ||
| - no-cache | ||
| content-length: | ||
| - '1360' | ||
| content-type: | ||
| - application/json; charset=utf-8 | ||
| date: | ||
| - Fri, 07 Feb 2025 22:56:56 GMT | ||
| expires: | ||
| - '-1' | ||
| pragma: | ||
|
|
@@ -43,12 +45,12 @@ interactions: | |
| - CONFIG_NOCACHE | ||
| x-content-type-options: | ||
| - nosniff | ||
| x-ms-ratelimit-remaining-subscription-global-writes: | ||
| - '11999' | ||
| x-ms-ratelimit-remaining-subscription-writes: | ||
| - '799' | ||
| x-msedge-ref: | ||
| - 'Ref A: 91D0426F1AC74686B7893DD629D80460 Ref B: CO6AA3150219009 Ref C: 2025-02-07T22:56:54Z' | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -171,6 +171,7 @@ def test_step_provider_registration_create(self, resource_group): | |||||
| '--incident-routing-service "Resource Provider Service as a Service" ' | ||||||
| '--incident-routing-team "RPaaS" ' | ||||||
| '--provider-version "2.0" ' | ||||||
| '--provider-type "Hidden, Internal" ' | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| '--provider-namespace "{providerNamespace}" ' | ||||||
| '--metadata {{\\"BypassManifestValidation\\":true}}') | ||||||
|
|
||||||
|
|
@@ -213,7 +214,8 @@ def test_step_resource_type_registration_create(self, resource_group): | |||||
| '--endpoints "[{{api-versions:[2019-01-01],locations:[WestUS]}}]" ' | ||||||
| '--regionality "Regional" ' | ||||||
| '--provider-namespace "{providerNamespace}" ' | ||||||
| '--resource-type "extensionresourcetype" ' | ||||||
| '--routing-type "ProxyOnly, Extension" ') | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| # EXAMPLE: /ResourceTypeRegistrations/get/ResourceTypeRegistrations_ListByProviderRegistration | ||||||
| @AllowLargeResponse() | ||||||
|
|
@@ -514,4 +516,4 @@ def test_step_sku_delete4(self, resource_group): | |||||
| '--nested-resource-type-third "nestedResourceTypeThird" ' | ||||||
| '--provider-namespace "{providerNamespace}" ' | ||||||
| '--resource-type "{resourceType}" ' | ||||||
| '--sku "{skuName}"') | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow this doc for customization https://azure.github.io/aaz-dev-tools/pages/usage/customization/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for parsing comma separated input for the following commands:
az providerhub provider-registration create --provider-type
az providerhub resource-type-registration create --routing-type
So that the user could enter something like:
az providerhub provider-registration create --provider-type "Hidden, Internal"