Update repair-button and repair-and-restore descriptions and --button-command help text #8488
Conversation
Modifying the repair-button --button-command text
|
Hi @divargas-msft, |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Modifying the summary for both repair-button and repair-and-restore to make them more accurate
Increasing version number as instructed by Adam Sandor
updating release history
divargas-msft
changed the title
| @@ -65,7 +65,7 @@ def load_arguments(self, _): | |||
| c.argument('repair_group_name', help='Name for new or existing resource group that will contain repair VM.') | |||
|
|
|||
| with self.argument_context('vm repair repair-button') as c: | |||
| c.argument('button_command', help='Button_command for repair VM.') | |||
| c.argument('button_command', help='Specific ALAR script being used for repair VM.') | |||
There was a problem hiding this comment.
is this just a flag parameter? or can it take values? If it can take in values, is this cmd only specified to run the alar2 script? If it's not alar specific, remove that mention and just describe what it does.
There was a problem hiding this comment.
@Sandido the --button-command needs to receive the name of an ALAR function/command as a value ( and it needs that value to work)
Minor wording fix Co-authored-by: Adam Sandor <[email protected]>
Minor wording fix Co-authored-by: Adam Sandor <[email protected]>
|
@Sandido your other 2 suggestions have been committed. At least you have any suggestion for the button command piece from repair VM button, this should be good to go |
Modifying the repair-button --button-command text
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.