Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[load] Adding CLI support for engine reference identity feature #8492

Merged

Conversation

Himanshu49
Copy link
Member

@Himanshu49 Himanshu49 commented Feb 19, 2025

Added two new parameter --engine-ref-ids and --engine-ref-id-type to 'az load test create' and 'az load test update' commands.
Added their corresponding validators, logic and tests.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 19, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️load
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd load test create cmd load test create added parameter engine_ref_id_type
⚠️ 1006 - ParaAdd load test create cmd load test create added parameter engine_ref_ids
⚠️ 1006 - ParaAdd load test update cmd load test update added parameter engine_ref_id_type
⚠️ 1006 - ParaAdd load test update cmd load test update added parameter engine_ref_ids

Copy link

Hi @Himanshu49,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Feb 19, 2025

@Himanshu49 Himanshu49 marked this pull request as ready for review February 26, 2025 11:01
@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 27, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 28, 2025
@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit f78d9f6 into Azure:main Feb 28, 2025
22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ load-1.6.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=116543830&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants