-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] az aks create/update: Update recording rule group create logic for managed prometheus addon #8499
Conversation
…for managed prometheus addon
️✔️Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, queued live test to validate the change, test passed!
- test_aks_create_with_azuremonitormetrics
- test_aks_update_with_azuremonitormetrics
BTW, please resolve merge conflict |
@FumingZhang Fixed merge conflict. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
[Release] Update index.json for extension [ aks-preview-13.0.0b8 ] : https://dev.azure.com/msazure/One/_build/results?buildId=116263651&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"
az aks create -n kaveeshcli22 -g kaveeshcli --disable-azure-monitor-metrics
Testing Guide
Scenario 1 : Region where TiP manifest is available
az aks create -n kaveeshcli22 -g kaveeshcli --location westcentralus --enable-azure-monitor-metrics"
and it should result in a success. (Currently the change is only deployed to westcentralus)Scenario 2 : Region where TiP manifest is not available
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics"
and it should result in a success.General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.