Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{ServiceConnector Passwordless} Make Fabric SQL target work without connstr_props #8501

Conversation

Tonychen0227
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 24, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️serviceconnector-passwordless
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks connection create mysql-flexible cmd aks connection create mysql-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd aks connection create mysql-flexible cmd aks connection create mysql-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd aks connection create postgres-flexible cmd aks connection create postgres-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd aks connection create postgres-flexible cmd aks connection create postgres-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd aks connection create sql cmd aks connection create sql added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd aks connection create sql cmd aks connection create sql added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd containerapp connection create fabric-sql cmd containerapp connection create fabric-sql added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd containerapp connection create fabric-sql cmd containerapp connection create fabric-sql added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd containerapp connection create mysql-flexible cmd containerapp connection create mysql-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd containerapp connection create mysql-flexible cmd containerapp connection create mysql-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd containerapp connection create postgres-flexible cmd containerapp connection create postgres-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd containerapp connection create postgres-flexible cmd containerapp connection create postgres-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd containerapp connection create sql cmd containerapp connection create sql added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd containerapp connection create sql cmd containerapp connection create sql added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd functionapp connection create fabric-sql cmd functionapp connection create fabric-sql added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd functionapp connection create fabric-sql cmd functionapp connection create fabric-sql added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd functionapp connection create mysql-flexible cmd functionapp connection create mysql-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd functionapp connection create mysql-flexible cmd functionapp connection create mysql-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd functionapp connection create postgres-flexible cmd functionapp connection create postgres-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd functionapp connection create postgres-flexible cmd functionapp connection create postgres-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd functionapp connection create sql cmd functionapp connection create sql added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd functionapp connection create sql cmd functionapp connection create sql added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd webapp connection create fabric-sql cmd webapp connection create fabric-sql added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd webapp connection create fabric-sql cmd webapp connection create fabric-sql added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd webapp connection create mysql-flexible cmd webapp connection create mysql-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd webapp connection create mysql-flexible cmd webapp connection create mysql-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd webapp connection create postgres-flexible cmd webapp connection create postgres-flexible added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd webapp connection create postgres-flexible cmd webapp connection create postgres-flexible added parameter fabric_workspace_uuid
⚠️ 1006 - ParaAdd webapp connection create sql cmd webapp connection create sql added parameter fabric_sql_db_uuid
⚠️ 1006 - ParaAdd webapp connection create sql cmd webapp connection create sql added parameter fabric_workspace_uuid

Copy link

Hi @Tonychen0227,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

Hi @Tonychen0227

Release Suggestions

Module: serviceconnector-passwordless

  • Please log updates into to src/serviceconnector-passwordless/HISTORY.rst
  • Update VERSION to 3.3.0 in src/serviceconnector-passwordless/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants