Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Fleet API 2025-03-01 #8589

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

frantran
Copy link
Member

@frantran frantran commented Mar 21, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az fleet ...

  • Removing preview from autoupgradeprofile items
  • Adding new command, az fleet autoupgadeprofile genenerate-update-run ...
  • Updating SDK to 2025-03-01

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @frantran,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Mar 21, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️fleet
rule cmd_name rule_message suggest_message
⚠️ 1004 - CmdPropRemove fleet autoupgradeprofile create cmd fleet autoupgradeprofile create removed property is_preview
⚠️ 1004 - CmdPropRemove fleet autoupgradeprofile delete cmd fleet autoupgradeprofile delete removed property is_preview
⚠️ 1001 - CmdAdd fleet autoupgradeprofile generate-update-run cmd fleet autoupgradeprofile generate-update-run added
⚠️ 1004 - CmdPropRemove fleet autoupgradeprofile list cmd fleet autoupgradeprofile list removed property is_preview
⚠️ 1004 - CmdPropRemove fleet autoupgradeprofile show cmd fleet autoupgradeprofile show removed property is_preview
⚠️ 1004 - CmdPropRemove fleet autoupgradeprofile wait cmd fleet autoupgradeprofile wait removed property is_preview

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 21, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan yonzhan requested review from kairu-ms and jsntcy March 22, 2025 06:20
@frantran frantran marked this pull request as draft March 24, 2025 18:25
@frantran frantran marked this pull request as ready for review March 26, 2025 00:00
@frantran frantran marked this pull request as draft March 26, 2025 00:04
@frantran frantran marked this pull request as ready for review March 26, 2025 19:01
@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file meant to be deleted? Maybe you used git mv instead of git cp.

Copy link
Member Author

@frantran frantran Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all files under src/fleet/azext_fleet/vendored_sdks/v2024_05_02_preview/* are meant to be deleted, as that is the "older" version

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, the list of changed files makes it look like this one file only has been deleted, but I see now that all the others are gone as well. They just show as renamed instead of deleted.

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

kairu-ms
kairu-ms previously approved these changes Mar 28, 2025
@frantran
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 8589 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

kairu-ms commented Apr 1, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@frantran
Copy link
Member Author

frantran commented Apr 1, 2025

/azp run

Copy link

Commenter does not have sufficient privileges for PR 8589 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 1, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

kairu-ms commented Apr 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

kairu-ms
kairu-ms previously approved these changes Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants