Skip to content

[AKS] Add option Ubuntu2204 to --os-sku for az aks nodepool add and az aks nodepool update #8597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anujmaheshwari1
Copy link

@anujmaheshwari1 anujmaheshwari1 commented Mar 24, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool add
az aks nodepool update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 24, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1010 - ParaPropUpdate aks create cmd aks create update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu'] to ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204']
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Windows2019', 'Windows2022', 'WindowsAnnual'] to ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204', 'Windows2019', 'Windows2022', 'WindowsAnnual']
⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool update update parameter os_sku: updated property choices from ['AzureLinux', 'Ubuntu'] to ['AzureLinux', 'Ubuntu', 'Ubuntu2204']

Copy link

Hi @anujmaheshwari1,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @anujmaheshwari1,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

Hi @anujmaheshwari1

Release Suggestions

Module: aks-preview

  • Update VERSION to 13.0.0b10 in src/aks-preview/setup.py

Notes

@@ -1720,7 +1720,7 @@
short-summary: The OS Type. Linux or Windows. Windows not supported yet for "VirtualMachines" VM set type.
- name: --os-sku
type: string
short-summary: The os-sku of the agent node pool. Ubuntu or CBLMariner when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set.
short-summary: The os-sku of the agent node pool. Ubuntu, CBLMariner or Ubuntu2204 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CBLMariner actually allowed here?

Maybe fix the docs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CBLMariner is no longer allowed: https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp?path=/resourceprovider/server/microsoft.com/containerservice/server/validation/validators/ossku/linux_validator.go&version=GBmaster&_a=contents

Henry, one of the leads for Mariner has confirmed that we should drop CBLMariner and replace it with AzureLinux in the docs instead.

updated the PR

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test in eastus2euap (as feature is not available in all regions) to validate the change, test passed!

  • test_aks_nodepool_add_with_ossku_ubuntu2204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants