-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[AKS] Add option Ubuntu2204
to --os-sku
for az aks nodepool add
and az aks nodepool update
#8597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[AKS] Add option Ubuntu2204
to --os-sku
for az aks nodepool add
and az aks nodepool update
#8597
Conversation
❌Azure CLI Extensions Breaking Change Test
|
Hi @anujmaheshwari1, |
Hi @anujmaheshwari1, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Release SuggestionsModule: aks-preview
Notes
|
@@ -1720,7 +1720,7 @@ | |||
short-summary: The OS Type. Linux or Windows. Windows not supported yet for "VirtualMachines" VM set type. | |||
- name: --os-sku | |||
type: string | |||
short-summary: The os-sku of the agent node pool. Ubuntu or CBLMariner when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set. | |||
short-summary: The os-sku of the agent node pool. Ubuntu, CBLMariner or Ubuntu2204 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CBLMariner actually allowed here?
Maybe fix the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CBLMariner is no longer allowed: https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp?path=/resourceprovider/server/microsoft.com/containerservice/server/validation/validators/ossku/linux_validator.go&version=GBmaster&_a=contents
Henry, one of the leads for Mariner has confirmed that we should drop CBLMariner and replace it with AzureLinux in the docs instead.
updated the PR
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Queued live test in eastus2euap (as feature is not available in all regions) to validate the change, test passed!
- test_aks_nodepool_add_with_ossku_ubuntu2204
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks nodepool add
az aks nodepool update
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.