{AKS} Rename to addon-autoscaling preview CLI to optimized-addon-scaling

[chihshenghuang]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
• My extension version conforms to the Extension version schema

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-client-tools-bot-prd]

❌Azure CLI Extensions Breaking Change Test

❌aks-preview

rule	cmd_name	rule_message	suggest_message
❌ 1007 - ParaRemove	aks create	cmd aks create removed parameter enable_addon_autoscaling	please add back parameter enable_addon_autoscaling for cmd aks create
❌ 1007 - ParaRemove	aks update	cmd aks update removed parameter disable_addon_autoscaling	please add back parameter disable_addon_autoscaling for cmd aks update
❌ 1007 - ParaRemove	aks update	cmd aks update removed parameter enable_addon_autoscaling	please add back parameter enable_addon_autoscaling for cmd aks update
⚠️ 1006 - ParaAdd	aks create	cmd aks create added parameter enable_optimized_addon_scaling
⚠️ 1006 - ParaAdd	aks update	cmd aks update added parameter disable_optimized_addon_scaling
⚠️ 1006 - ParaAdd	aks update	cmd aks update added parameter enable_optimized_addon_scaling

[azure-client-tools-bot-prd]

Hi @chihshenghuang,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

[yonzhan]

Thank you for your contribution! We will review the pull request and get back to you soon.

[github-actions]

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

[github-actions]

• For more info about extension versioning, please refer to Extension version schema

[FumingZhang]

Queued live test to validate the change, test passed!

• test_aks_create_with_optimized_addon_scaling
• test_aks_update_with_optimized_addon_scaling

[FumingZhang]

#8618 just merged and caused merge conflicts. Please update the recording files, either regenerate them or manually update the API version used in the requests sent to AKS.

[chihshenghuang]

#8618 just merged and caused merge conflicts. Please update the recording files, either regenerate them or manually update the API version used in the requests sent to AKS.

Merge the latest change.

@FumingZhang do you know how to fix the azdev scan error shown below? I run the azdev scan command locally and got the result below. I didn't touch or update "management.azure.com{dcr_resource_id}?api-version=2022-06-01" which is complained by the azdev scan.

I don't understand why other PRs touch aks-preview were not blocked by this code which was added long time ago.

{
  "scan_results": {
    "/home/chih/aks/azure-cli-extensions/src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py": [
      {
        "redaction_token": "+++",
        "secret_index": [
          221106,
          221889
        ],
        "secret_name": "UrlCredentials",
        "secret_value": "management.azure.com{dcr_resource_id}?api-version=2022-06-01\"\n            self.cmd(\n                get_cmd,\n                checks=[\n                    self.check(\n                        \"properties.destinations.logAnalytics[0].workspaceResourceId\",\n                        f\"{workspace_resource_id}\",\n                    )\n                ],\n            )\n\n            assert False\n        except Exception:\n            # do nothing as this is expected\n            {}\n\n        # make sure monitoring can be smoothly disabled\n        self.cmd(f\"aks disable-addons -a monitoring -g={resource_group} -n={aks_name}\")\n\n        # delete\n        self.cmd(\n            f\"aks delete -g {resource_group} -n {aks_name} --yes --no-wait\",\n            checks=[self.is_empty()],\n        )\n\n    "
      }
    ]
  },
  "secrets_detected": true
}

[FumingZhang]

@chihshenghuang you can ignore the failure reported by Azure.azure-cli-extensions (azdev scan ( Medium Confidence ) on Modified Extensions), that's a false alert and it won't block your PR.