Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Add azdev style&linter into github workflow #8627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AllyW
Copy link
Member

@AllyW AllyW commented Apr 2, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

This pr executed azdev linter & style using github workflow, to avoid using any token and ensure security in scripting running.

In the future, we can deploy the other CI tasks into github workflow.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 2, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @AllyW,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Apr 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@AllyW AllyW changed the title {CI} Add azdev style&linter into github action {CI} Add azdev style&linter into github workflow Apr 2, 2025
Copy link

github-actions bot commented Apr 2, 2025

@wangzelin007
Copy link
Member

@AllyW
Could you share the execution time comparison between:

  • azdev style & linter in GitHub Actions
  • The same checks in Azure DevOps pipeline (5m-10m)
    image

@AllyW
Copy link
Member Author

AllyW commented Apr 2, 2025

@AllyW Could you share the execution time comparison between:

  • azdev style & linter in GitHub Actions
  • The same checks in Azure DevOps pipeline (5m-10m)
    image

Tested in my folk repo with one module changed, GH azdev style and GH azdev linter execution time is as following:
image
image

Ado pipeline execution time can be checked after merged and compared from main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants