Skip to content

Restrict VirtualMachines node pool manual profile vm_sizes field to support single sku size #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

reneeli123
Copy link
Contributor

@reneeli123 reneeli123 commented Apr 29, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --vm-sizes
az aks nodepool add --vm-sizes
az aks nodepool manual-scale add
az aks nodepool manual-scale update
az aks nodepool manual-scale delete

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 29, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @reneeli123,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @reneeli123,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

github-actions bot commented Apr 29, 2025

Hi @reneeli123

Release Suggestions

Module: aks-preview

  • Update VERSION to 14.0.0b7 in src/aks-preview/setup.py

Notes

@yonzhan yonzhan requested review from zhoxing-ms and yanzhudd April 29, 2025 06:57
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 29, 2025
@reneeli123 reneeli123 force-pushed the reneel/mixed-sku-size branch from bdeafb9 to 9032d62 Compare April 29, 2025 08:32
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 29, 2025
@reneeli123 reneeli123 changed the title Add support for v20250202preview changes related to single SKU size in the mixed SKU API manual profile. Restrict VirtualMachines node pool manual profile vm_sizes field to support single sku size Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants