-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Upgrading to the latest databox stable api version #8769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
databox available-skus | cmd databox available-skus added |
||
databox job create | cmd databox job create added parameter model |
||
databox job list | cmd databox job list added parameter pagination_limit |
||
databox job list | cmd databox job list added parameter pagination_token |
||
databox job mitigate | cmd databox job mitigate added |
Hi @GovardhanaDK, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the DataBox extension to use the 2025-02-01 API version, adds support for new device models and flags, and updates associated tests and metadata.
- Bumped API version and CLI core version to 2025-02-01 / 2.70.0
- Introduced
--model
and updated schema to include SKU model, and test for--transfer-all-blobs
- Added test assets (certificates and private key) and updated scenario tests for available SKUs and new flags
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
src/databox/testkey.pvk | Added RSA private key for tests (security risk) |
src/databox/testcert.cer, testcert-chain.pem | Added test certificates |
src/databox/azext_databox/tests/latest/test_databox_scenario.py | Updated SKU count check and added --model / --transfer-all-blobs in scenario test |
src/databox/azext_databox/azext_metadata.json | Bumped azext.minCliCoreVersion to 2.70.0 |
src/databox/azext_databox/aaz/latest/databox/job/_*.py (create, list, show, update, etc.) | Bumped API version, added read-only flags, introduced SKU model & identity changes |
src/databox/azext_databox/aaz/latest/databox/_available_skus.py | Added AvailableSkus command with new schema and pagination support |
src/databox/azext_databox/tests/latest/test_databox_scenario.py
Outdated
Show resolved
Hide resolved
src/databox/azext_databox/tests/latest/test_databox_scenario.py
Outdated
Show resolved
Hide resolved
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 8769 in repo Azure/azure-cli-extensions |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 8769 in repo Azure/azure-cli-extensions |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.