feat(acns): add transit encryption options for az create and update commands #8784
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter acns_transit_encryption_type |
||
| aks update | cmd aks update added parameter acns_transit_encryption_type |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying a transit encryption type parameter (None or WireGuard) for ACNS during both cluster creation and update.
- Bump version in setup.py
- Update linter exclusions for the new parameter
- Introduce tests and enable handling in the managed cluster decorator, custom command code, and parameter definitions
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version bump to 18.0.0b3 |
| src/aks-preview/linter_exclusions.yml | Added linter rule exclusions for acns_transit_encryption_type |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Added tests for get_acns_transit_encryption_type functionality |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Added tests for cluster creation and update with transit encryption type |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Integrated handling for transit encryption type in cluster network profile setup and update |
| src/aks-preview/azext_aks_preview/custom.py | Extended creation and update command functions with new parameter |
| src/aks-preview/azext_aks_preview/_params.py | Defined argument and enum for acns_transit_encryption_type parameter |
| src/aks-preview/azext_aks_preview/_consts.py | Added constants for transit encryption types |
| src/aks-preview/HISTORY.rst | Updated history notes for new option |
| raise MutuallyExclusiveArgumentError( | ||
| "--disable-acns-security and --disable-acns cannot be used with acns_transit_encryption_type." | ||
| ) | ||
| return self.raw_param.get("acns_transit_encryption_type") |
There was a problem hiding this comment.
[nitpick] Consider storing the retrieved value of 'acns_transit_encryption_type' in a local variable and returning that variable rather than calling self.raw_param.get() again. This would improve clarity and avoid potential inconsistencies.
| return self.raw_param.get("acns_transit_encryption_type") | |
| return acns_transit_encryption_type |
Copilot uses AI. Check for mistakes.
|
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_create_with_transit_encryption_type
- test_aks_update_with_transit_encryption_type
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please fix failed CI checks and resolve merge conflicts
|
…ommands Signed-off-by: Quang Nguyen <[email protected]>
|
applied fix for failed test cases in PR #8798 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Creates commands for specify transit encryption type (None, WireGuard) during cluster creation and update for aks-preview.
az aks create --enable-acns --acns-transit-encryption-type <None|WireGuard>az aks update --enable-acns --acns-transit-encryption-type <None|WireGuard>This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.