Skip to content

Conversation

@kshitij-microsoft
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings December 8, 2025 20:46
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @kshitij-microsoft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 8, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for a default_deployment_template parameter to the model creation functionality in Azure Machine Learning Services CLI extension. This integration enables users to specify a default deployment template when creating models.

Key Changes

  • Added default_deployment_template parameter to ml_model_create function signature
  • Updated Model constructor call to pass the new parameter
  • Added CLI argument definition for --default-deployment-template option

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/machinelearningservices/azext_mlv2/manual/custom/model.py Added default_deployment_template parameter to function signature and Model constructor; contains misplaced argument definition code
src/machinelearningservices/azext_mlv2/manual/_params/_model_params.py Added proper CLI argument definition for --default-deployment-template in the parameter loading function

@necusjz
Copy link
Member

necusjz commented Dec 9, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

jayesh-tanna
jayesh-tanna previously approved these changes Dec 9, 2025
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 9, 2025

Please fix CI issues

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Hi @kshitij-microsoft

Release Suggestions

Module: machinelearningservices

  • Please log updates into to src/machinelearningservices/HISTORY.rst
  • Update VERSION to 3.0.0 in src/machinelearningservices/setup.py

Notes

@necusjz
Copy link
Member

necusjz commented Dec 10, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@kshitij-microsoft kshitij-microsoft changed the base branch from main to ml-dev December 11, 2025 11:26
@necusjz
Copy link
Member

necusjz commented Dec 14, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 15, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants