Skip to content

Conversation

@rigidit
Copy link

@rigidit rigidit commented Dec 16, 2025

Fix test_submit in test_quantum_jobs that relied on returning jobs in wrong order


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 16, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @rigidit,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 16, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Auto-Assign Auto assign by bot labels Dec 16, 2025
@github-actions
Copy link

@yonzhan yonzhan requested a review from kairu-ms December 16, 2025 23:53
@yonzhan yonzhan requested review from jsntcy and necusjz December 17, 2025 00:36
@rigidit rigidit marked this pull request as ready for review December 19, 2025 08:45
Copilot AI review requested due to automatic review settings December 19, 2025 08:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the test_submit test in test_quantum_jobs.py which was making incorrect assumptions about the default ordering of job listings. The test was expecting jobs to be returned in chronological order (oldest first), but the actual API behavior returns jobs in reverse chronological order (newest first).

Key Changes

  • Updated assertions for --top 1 to expect the most recently submitted job (IonQ) instead of the oldest job (Rigetti)
  • Updated assertions for --skip 1 to expect Rigetti jobs after skipping the most recent IonQ job
  • Swapped the expected provider names in assertions to match the actual reverse chronological ordering

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rigidit rigidit requested a review from kikomiss December 24, 2025 19:01
@kikomiss
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 9481 in repo Azure/azure-cli-extensions

@kikomiss
Copy link
Contributor

@kairu-ms this PR only touches existing tests and could be merged right away. No extension release needed.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 27, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants