-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Quantum: fix quantum jobs test #9481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @rigidit, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the test_submit test in test_quantum_jobs.py which was making incorrect assumptions about the default ordering of job listings. The test was expecting jobs to be returned in chronological order (oldest first), but the actual API behavior returns jobs in reverse chronological order (newest first).
Key Changes
- Updated assertions for
--top 1to expect the most recently submitted job (IonQ) instead of the oldest job (Rigetti) - Updated assertions for
--skip 1to expect Rigetti jobs after skipping the most recent IonQ job - Swapped the expected provider names in assertions to match the actual reverse chronological ordering
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9481 in repo Azure/azure-cli-extensions |
|
@kairu-ms this PR only touches existing tests and could be merged right away. No extension release needed. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Fix test_submit in test_quantum_jobs that relied on returning jobs in wrong order
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.