Skip to content

Conversation

@2003LK
Copy link

@2003LK 2003LK commented Dec 19, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings December 19, 2025 21:02
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 19, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️databricks
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd databricks workspace create cmd databricks workspace create added parameter compute_mode
⚠️ 1006 - ParaAdd databricks workspace update cmd databricks workspace update added parameter compute_mode

@azure-client-tools-bot-prd
Copy link

Hi @2003LK,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Azure Databricks extension to use API version 2025-10-01-preview and introduces serverless compute mode support along with additional enhanced security compliance standards.

Key changes:

  • Updated API version from 2024-05-01 to 2025-10-01-preview across all Databricks commands
  • Added serverless compute mode support with --compute-mode parameter (Hybrid/Serverless)
  • Expanded compliance standards to include HITRUST, CYBER_ESSENTIAL_PLUS, FEDRAMP_HIGH, and others
  • Made managed_resource_group optional (not required for Serverless workspaces)

Reviewed changes

Copilot reviewed 33 out of 44 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/databricks/azext_databricks/tests/latest/test_databricks_scenario.py Added new serverless tests and updated existing tests with hardcoded resource groups
src/databricks/azext_databricks/custom.py Added logic to skip managed resource group for serverless mode
src/databricks/azext_databricks/aaz/latest/databricks/workspace/_create.py Added compute_mode parameter, made managedResourceGroupId conditional, includes debug print statements
src/databricks/azext_databricks/aaz/latest/databricks/workspace/_update.py Added compute_mode parameter and expanded compliance standards enum
src/databricks/azext_databricks/aaz/latest/databricks/workspace/_*.py Updated API version to 2025-10-01-preview and added computeMode property
src/databricks/azext_databricks/aaz/latest/databricks/access_connector/_*.py Updated API version to 2025-10-01-preview
src/databricks/azext_databricks/tests/latest/recordings/*.yaml Updated test recordings with new API version and future dates
src/databricks/HISTORY.rst Added 1.2.0b1 release notes

'vnet_name': self.create_random_name(prefix='vnet', length=12),
'subnet_name': self.create_random_name(prefix='subnet', length=12),
'nsg_name': self.create_random_name(prefix='nsg', length=12),
'resource_group_exempt': "auto-test-databricks-g9",
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is using a hardcoded resource group name "auto-test-databricks-g9" instead of the dynamically generated resource group from the test decorator. This bypasses the test framework's resource cleanup mechanisms and may cause resource leaks or test conflicts. The test should use the 'rg' variable that is provided by the ResourceGroupPreparer decorator.

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These hard coded resource group names were necessary for tests in the team's subscription, due to subscription policy (the resource group has an exemption). Please let me know if there's another way to go about this testing without hardcoding an RG name!

'subnet_name': self.create_random_name(prefix='subnet', length=12),
'npe_name': self.create_random_name(prefix='npe', length=12),
'nsg_name': self.create_random_name(prefix='nsg', length=12),
'resource_group_exempt': "auto-test-databricks-g9",
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is using a hardcoded resource group name "auto-test-databricks-g9" instead of the dynamically generated resource group from the test decorator. This bypasses the test framework's resource cleanup mechanisms and may cause resource leaks or test conflicts. The test should use the 'rg' variable that is provided by the ResourceGroupPreparer decorator.

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Dec 19, 2025
@2003LK
Copy link
Author

2003LK commented Dec 20, 2025

@microsoft-github-policy-service agree company="Microsoft"

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Dec 20, 2025
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants