[Azure Migrate Local] Start migration command, preview channel versioning & new commands for replication #9493
+6,552
−511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| migrate get-discovered-server | cmd migrate get-discovered-server added property is_preview |
||
| migrate local replication get | cmd migrate local replication get added |
||
| migrate local replication get-job | cmd migrate local replication get-job added property is_preview |
||
| migrate local replication init | cmd migrate local replication init added property is_preview |
||
| migrate local replication list | cmd migrate local replication list added |
||
| migrate local replication new | cmd migrate local replication new added property is_preview |
||
| migrate local replication remove | cmd migrate local replication remove added property is_preview |
||
| migrate local start-migration | cmd migrate local start-migration added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds new replication management commands and resolves preview versioning issues for the Azure Migrate Local extension. The version is bumped from 3.0.0b1 to 4.0.0b1 to introduce new functionality for listing, retrieving, and starting migration of replicating servers.
Key changes:
- Added three new commands:
az migrate local replication list,az migrate local replication get, andaz migrate local start-migration - Fixed several bugs related to enum value access, custom location region retrieval, and AMH solution configuration
- Added comprehensive unit tests (~4000+ lines) covering all new and existing functionality
- Enhanced extension configuration matching logic to detect and update mismatched configurations
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump from 3.0.0b1 to 4.0.0b1 |
| test_migrate_commands.py | Added extensive unit tests for new list, get, and start-migration commands |
| custom.py | Implemented new command functions and removed redundant docstrings |
| commands.py | Added new command registrations with preview flag |
| _params.py | Added parameter definitions for new commands |
| _help.py | Added comprehensive help documentation for new commands |
| HISTORY.rst | Added release notes for 4.0.0b1 |
| helpers/replication/init/_setup_policy.py | Fixed enum value access by adding .value |
| helpers/replication/init/_setup_permissions.py | Fixed AMH solution tool name update logic |
| helpers/replication/init/_setup_extension.py | Enhanced configuration matching and update logic |
| helpers/replication/new/_validate.py | Fixed return value to include subscription_id |
| helpers/replication/new/_execute_new.py | Added custom location region retrieval and target RG creation |
| helpers/replication/list/_execute_list.py | New module for listing protected items |
| helpers/replication/get/_execute_get.py | New module for retrieving protected item details |
| helpers/migration/start/*.py | New modules for migration validation, parsing, and execution |
| Various init.py files | Added copyright headers to new module init files |
Collaborator
|
Please fix CI issues |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 9493 in repo Azure/azure-cli-extensions |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Added the new start migration command.
Resolved preview versioning issues.
Introduced list and get commands for replication.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.