Skip to content

Conversation

@a0x1ab
Copy link
Member

@a0x1ab a0x1ab commented Dec 29, 2025

  • Fixes az notification-hub credential gcm update to not fail when the service response omits properties.gcmCredential.
  • Replaces strict output selection with a tolerant selector (get()), returning {} when the credential block is absent.
  • Prevents false ResourceNotFoundError

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az notification-hub

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

AAZ output shaping no longer requires properties.gcmCredential; return {} when missing to avoid ResourceNotFoundError.
Copilot AI review requested due to automatic review settings December 29, 2025 06:18
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 29, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @a0x1ab,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @a0x1ab

Release Suggestions

Module: notification-hub

  • Please log updates into to src/notification-hub/HISTORY.rst
  • Update VERSION to 2.0.0b2 in src/notification-hub/setup.py

Notes

@yonzhan yonzhan requested a review from jsntcy December 29, 2025 06:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the az notification-hub credential gcm update command to handle cases where the Azure service response omits the properties.gcmCredential field, preventing false ResourceNotFoundError exceptions.

Key Changes:

  • Replaced strict selector method required() with tolerant get() method
  • Added null/undefined check with empty dictionary fallback to gracefully handle missing credentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants