-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Core} Top-level tab completion performance improvements #32616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
{Core} Top-level tab completion performance improvements #32616
Conversation
🔄AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
| import os | ||
| import sys | ||
|
|
||
| if sys.platform == 'win32': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emulating skips of incumbent tests, I believe it may be a CI/CD limitation.
c3e4eb1 to
d1a0f27
Compare
Related command
Description
This PR aims to improve the performance of top-level tab-completion, (i.e.,
az [TAB]).Local testing has shown significant improvements to performance, going from over 5 seconds to under 1 second.
Testing conditions:
Testing Guide
Please ensure your terminal is set up for tab-completion.
Test changes with
az [TAB].History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.