[Storage] az storage account create/update: Add breaking change warning for --min-tls-version values tls1_0 and tls1_1
#32652
+201
−808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tls1_0 or tls1_1, we send tls1_2 instead
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account create | cmd storage account create added property deprecate_info_target |
||
| storage account update | cmd storage account update added property deprecate_info_target |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds breaking change warnings and automatic upgrade behavior for deprecated TLS versions (1.0 and 1.1) in Azure Storage account commands. When users specify TLS1_0 or TLS1_1 for the --min-tls-version parameter, the CLI will automatically use TLS1_2 instead and display a warning.
Changes:
- Adds logic to automatically upgrade deprecated TLS versions (1.0, 1.1) to TLS 1.2
- Registers breaking change warnings for the deprecation
- Updates help text to reflect the retirement of TLS 1.0 and 1.1
- Updates tests to verify the new behavior
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
account.py |
Adds TLS version upgrade logic and warning in create/update functions |
_params.py |
Updates help text to document TLS 1.0/1.1 retirement |
_breaking_change.py |
Registers breaking change warnings for the deprecation |
test_storage_account_scenarios.py |
Updates tests to expect TLS1_2 when TLS1_0/1.1 are specified |
| Test recordings | Updates test recordings to reflect new behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
when user specify tls1_0 or tls1_1, we send tls1_2 instead
Testing Guide
History Notes
[Storage]
az storage account create/update: Set--min-tls-versiontotls1_2if the value provided istls1_0andtls1_1This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.