Conversation
huiii99
requested review from
DanielMicrosoft,
ReaNAiveD,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network nat gateway create | cmd network nat gateway create update parameter pip_addresses_v6: updated property name from pip_addresses_v6 to pip_addresses_v6_input |
||
| network nat gateway create | cmd network nat gateway create update parameter pip_addresses_v6: updated property type from List<Object> to List<String> |
||
| network nat gateway create | cmd network nat gateway create update parameter pip_prefixes_v6: updated property name from pip_prefixes_v6 to pip_prefixes_v6_input |
||
| network nat gateway create | cmd network nat gateway create update parameter pip_prefixes_v6: updated property type from List<Object> to List<String> |
||
| network nat gateway update | cmd network nat gateway update update parameter pip_addresses_v6: updated property name from pip_addresses_v6 to pip_addresses_v6_input |
||
| network nat gateway update | cmd network nat gateway update update parameter pip_addresses_v6: updated property type from List<Object> to List<String> |
||
| network nat gateway update | cmd network nat gateway update update parameter pip_prefixes_v6: updated property name from pip_prefixes_v6 to pip_prefixes_v6_input |
||
| network nat gateway update | cmd network nat gateway update update parameter pip_prefixes_v6: updated property type from List<Object> to List<String> |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates az network nat gateway to accept IPv6 public IP address/prefix inputs in the same user-friendly “names or IDs” form as the existing IPv4 parameters, addressing inconsistent CLI behavior.
Changes:
- Add new
--public-ip-addresses-v6/--public-ip-prefixes-v6arguments and map them into the NAT Gateway model fields. - Introduce/extend tests covering StandardV2 NAT Gateway creation using IPv6 public IPs/prefixes.
- Simplify existing NAT Gateway test setup by removing
--ip-tagsusage in public IP/prefix creation.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_natgateway_commands.py |
Adds coverage for creating a StandardV2 NAT Gateway with IPv6 addresses/prefixes using the new CLI parameters. |
src/azure-cli/azure/cli/command_modules/network/operations/nat.py |
Adds new AAZ args for IPv6 PIP addresses/prefixes and wires them into pre-operations for create/update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
huiii99
changed the title
az network nat gateway--public-ip-addresses-v6 and --public-ip-prefixes-v6 to az network nat gateway
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Member
|
instead of introducing new parameters, we'd better modify existing parameters: --pip-addresses-v6 and --pip-prefixes-v6, to make them has the same behaviour. |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
huiii99
force-pushed
the
fix-inconsistent-ipv6-param-behavior
branch
from
1948ffb to
fb455c1
Compare
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
1 similar comment
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
huiii99
force-pushed
the
fix-inconsistent-ipv6-param-behavior
branch
from
8b764cf to
2c076ff
Compare
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
huiii99
changed the title
--public-ip-addresses-v6 and --public-ip-prefixes-v6 to az network nat gatewayaz network nat gateway
huiii99
changed the title
az network nat gatewayaz network nat gateway
necusjz
reviewed
Apr 16, 2026
necusjz
reviewed
Apr 16, 2026
necusjz
reviewed
Apr 16, 2026
huiii99
force-pushed
the
fix-inconsistent-ipv6-param-behavior
branch
from
2c076ff to
867e368
Compare
fix: apply review suggestion fix: retain legacy JSON format and introduce the same behavior as IPv4 dev dev dev dev fix: line too long style error dev
huiii99
force-pushed
the
fix-inconsistent-ipv6-param-behavior
branch
from
c97926a to
5f51e42
Compare
necusjz
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network nat gateway create/updateDescription
Fixes #33167
aaz Azure/aaz#984
The existing
--pip-addresses-v6and--pip-prefixes-v6parameters onaz network nat gateway create/updaterequire complex JSON input ([{"id":"/subscriptions/.../publicIPAddresses/..."}]), while the IPv4 counterparts (--public-ip-addresses,--public-ip-prefixes) accept simple resource names or IDs. This inconsistency is confusing for users.This PR introduces user-friendly
--pip-addresses-v6and--pip-prefixes-v6parameters that accept either a name or an ID (space-separated), matching the behavior of existing IPv4 parameters while preserving the traditional JSON format.Testing Guide
az network nat gateway createwith--pip-addresses-v6az network nat gateway updatewith--pip-addresses-v6History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.