Skip to content

fix: wrap handleCommonOptions error with NetworkNotReadyErrorMsg #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
behzad-mir wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: wrap handleCommonOptions error with NetworkNotReadyErrorMsg #4411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion network/network_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (nm *networkManager) newNetworkImpl(nwInfo *EndpointInfo, extIf *externalIn
err := nm.handleCommonOptions(ifName, nwInfo)
if err != nil {
logger.Error("handleCommonOptions failed with", zap.Error(err))
return nil, err
return nil, errors.Wrap(err, NetworkNotReadyErrorMsg)
Copy link
Copy Markdown
Contributor

@QxBytes QxBytes Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how this particular string in the error message changes the behavior of kubelet?
If there is an ADD failure doesn't it already retry?

Also this error message string seems to be used in the context of swiftv2 mtpnc, rather than the vm's networking which applies to all scenarios (even non-swiftv2)

}

// Create the network object.
Expand Down
Loading