[Internal] Binary Encoding: Adds Support for User String Encoding #5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Maya-Painter
changed the title
Maya-Painter
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
Maya-Painter
commented
Mar 3, 2025
adityasa
reviewed
Mar 6, 2025
adityasa
reviewed
Mar 6, 2025
adityasa
reviewed
Mar 18, 2025
adityasa
reviewed
Mar 18, 2025
Microsoft.Azure.Cosmos/src/Json/IReadOnlyJsonStringDictionary.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
Mar 18, 2025
Maya-Painter
commented
Mar 21, 2025
adityasa
reviewed
Mar 21, 2025
adityasa
reviewed
Mar 21, 2025
| return false; | ||
| } | ||
|
|
||
| return this.checksum == other.checksum; |
There was a problem hiding this comment.
The checksum is generated by hashing each incoming string with the previous hash as the seed. If the checksums are the same the dictionaries will definitely contain the same strings in the same order.
sboshra
reviewed
Mar 26, 2025
| { | ||
| bool TryGetString(int index, out UtfAllString value); | ||
|
|
||
| bool TryGetIndex(Utf8Span value, out int index); |
There was a problem hiding this comment.
There is a matching TryGetIndex function in the BE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for reading and writing user string encoded binary data in JsonReader, JsonWriter, and JsonNavigator.
Note: This is being introduced to support an internal scenario. For now, user string encoded data will NOT be sent over the wire to the client.
Type of change