[Internal] ClientRetryPolicy: Adds Code to Apply Partition Level Override When a Requested Cancellation Token Expires #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kundadebdatta
changed the title
kundadebdatta
added
auto-merge
kundadebdatta
changed the title
kundadebdatta
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
ananth7592
previously approved these changes
Mar 11, 2025
kundadebdatta
force-pushed
the
users/kundadebdatta/5060_ppaf_add_partition_level_override_on_ct_expiry
branch
from
c50b59a to
30de5b2
Compare
…itiated failover.
auto-merge was automatically disabled
March 21, 2025 05:15
Pull request was converted to draft
…n_level_override_on_ct_expiry
…n_level_override_on_ct_expiry
NaluTripician
previously approved these changes
Mar 24, 2025
…n_level_override_on_ct_expiry
…n_level_override_on_ct_expiry
kirankumarkolli
previously approved these changes
Mar 26, 2025
kundadebdatta
dismissed stale reviews from kirankumarkolli and FabianMeiswinkel
via
18f660c
…n_level_override_on_ct_expiry
kirankumarkolli
approved these changes
Mar 26, 2025
NaluTripician
approved these changes
Mar 26, 2025
microsoft-github-policy-service
bot
deleted the
users/kundadebdatta/5060_ppaf_add_partition_level_override_on_ct_expiry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Background:
During one of the backend drills, it was identified that when the following quorum loss condition is met, and the user provides a cancellation token, SDK honors the token, however doesn't apply the partition level fail over for the offending partition:
Observation:
Fix:
This PR is fixing the above behavior to apply partition level override, when a cancellation token gets expired. In order to avoid false positives, the cancellation token based failovers are currently based on certain thresholds, which could be overridden by setting the following environment variables:
AZURE_COSMOS_PPCB_CONSECUTIVE_FAILURE_COUNT_FOR_READSandAZURE_COSMOS_PPCB_CONSECUTIVE_FAILURE_COUNT_FOR_WRITES.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5060