Adding a new Capability for accepting Rntbd headers #5068
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
| @@ -11,6 +11,7 @@ internal enum SDKSupportedCapabilities : ulong | |||
| None = 0, | |||
| PartitionMerge = 1 << 0, | |||
| ChangeFeedWithStartTimePostMerge = 1 << 1, | |||
| ThroughputBucketing = 1 << 2 | |||
| ThroughputBucketing = 1 << 2, | |||
| AcceptNewRntbdTokens = 1 << 3 | |||
There was a problem hiding this comment.
Please make sure that JAVA SDK capabilites also aligns
There was a problem hiding this comment.
I will talk to Abhijeet on the same on Monday.
| @@ -11,6 +11,7 @@ internal enum SDKSupportedCapabilities : ulong | |||
| None = 0, | |||
| PartitionMerge = 1 << 0, | |||
| ChangeFeedWithStartTimePostMerge = 1 << 1, | |||
| ThroughputBucketing = 1 << 2 | |||
| ThroughputBucketing = 1 << 2, | |||
| AcceptNewRntbdTokens = 1 << 3 | |||
There was a problem hiding this comment.
| AcceptNewRntbdTokens = 1 << 3 | |
| AcceptUnknownRntbdTokens = 1 << 3 | |
| [TestMethod] | ||
| public async Task VerifySDKCapabilitites() | ||
| { | ||
| // method to ensure passing new capabilities doesnt hurt the basic operations |
There was a problem hiding this comment.
By-default already capabilityis included and existing test corpus already covers it right?
There was a problem hiding this comment.
thats right. I just wanted to be 100%. I will remove this test.
Pull Request Template
Description
This change is to add a new capability for accepting new Rntbd headers from the backend.