Skip to content

[Internal] Binary Encoding: Fixes DateTime Parsing Issue #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabianMeiswinkel merged 7 commits into from
Apr 17, 2025
Merged

[Internal] Binary Encoding: Fixes DateTime Parsing Issue #5133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a576ba1
Code changes to fix date parsing issue with binary encoding.
kundadebdatta Apr 15, 2025
426cbc9
Code changes to use DateTime parse.
kundadebdatta Apr 15, 2025
2cff395
Merge branch 'master' into users/kundadebdatta/5132_fix_date_parsing_…
kundadebdatta Apr 15, 2025
ef6f366
Merge branch 'master' into users/kundadebdatta/5132_fix_date_parsing_…
kundadebdatta Apr 15, 2025
b965f1c
Merge branch 'master' into users/kundadebdatta/5132_fix_date_parsing_…
kundadebdatta Apr 15, 2025
760e49c
Merge branch 'master' into users/kundadebdatta/5132_fix_date_parsing_…
kundadebdatta Apr 16, 2025
e98df27
Merge branch 'master' into users/kundadebdatta/5132_fix_date_parsing_…
kundadebdatta Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Microsoft.Azure.Cosmos/src/Json/Interop/CosmosDBToNewtonsoftWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public override void WriteValue(decimal value)
/// <param name="value">The <see cref="DateTime"/> value to write.</param>
public override void WriteValue(DateTime value)
{
this.WriteValue(value.ToString());
Comment thread
FabianMeiswinkel marked this conversation as resolved.
this.WriteValue(value.ToString("O"));
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Json/NewtonsoftInteropTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public void AllPrimitivesObjectTest()
new JProperty("string", "XCPCFXPHHF"),
new JProperty("boolean", true),
new JProperty("null", null),
new JProperty("datetime", "2526-07-11T18:18:16.4520716"),
new JProperty("datetime", DateTime.Parse("2526-07-11T18:18:16.4520716")),
Comment thread
FabianMeiswinkel marked this conversation as resolved.
new JProperty("spatialPoint", new JObject(
new JProperty("type", "Point"),
new JProperty("coordinate", new double[] { 118.9897, -46.6781 }))),
Expand Down
Loading