[Internal] Thin Client Integration: Fixes the ThinClientTransportSerializer to avoid creating memory stream.#5137
Merged
kirankumarkolli merged 5 commits intomasterfrom Apr 25, 2025
Conversation
aavasthy
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
1 task
aavasthy
changed the title
kirankumarkolli
previously approved these changes
Apr 17, 2025
kundadebdatta
approved these changes
Apr 23, 2025
Member
kundadebdatta
left a comment
kundadebdatta
left a comment
There was a problem hiding this comment.
Approved with minor suggestions.
kirankumarkolli
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Optimize the serialization logic by avoiding the creation of a new large MemoryStream every time by switching to a pooled byte array using ArrayPool.Shared. Instead of allocating a fresh buffer inside the stream, now renting a reusable one, copying data into it, and wrapping it with MemoryStream. This reduces memory usage.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5070