Skip to content

[Internal] Thin Client Integration: Fixes location cache update for thinclient read and write locations.#5152

Merged
kirankumarkolli merged 5 commits intomasterfrom
users/aavasthy/fixlocationcache
May 1, 2025
Merged

[Internal] Thin Client Integration: Fixes location cache update for thinclient read and write locations.#5152
kirankumarkolli merged 5 commits intomasterfrom
users/aavasthy/fixlocationcache

Conversation

@aavasthy
Copy link
Copy Markdown
Contributor

@aavasthy aavasthy commented Apr 29, 2025

Pull Request Template

Description

The location cache overrides the thinclient read and write endpoint value with default endpoint value after GetDatabaseAccount refresh call is made. This leads to 410 error getting generated on create and read item requests via thinclient mode due to wrong endpoint value.
As part of the fix, updating the location cache code logic for setting thinclient read and write endpoint location.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #5151

Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Comment thread Microsoft.Azure.Cosmos/src/Routing/LocationCache.cs
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Copy link
Copy Markdown
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kundadebdatta kundadebdatta added the auto-merge Enables automation to merge PRs label Apr 30, 2025
@kirankumarkolli kirankumarkolli merged commit 23720f3 into master May 1, 2025
26 checks passed
@kirankumarkolli kirankumarkolli deleted the users/aavasthy/fixlocationcache branch May 1, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs thin-client-integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Internal] Thin Client Integration: Fix location cache update for thinclient read and write locations.

4 participants