[INTERNAL] SessionRetry: Adds support to yield immediately after the original attempt when READ_SESSION_NOT_AVAILABLE error is thrown#5201
Merged
kirankumarkolli merged 13 commits intomasterfrom May 20, 2025
Conversation
dibahlfi
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kirankumarkolli
requested changes
May 15, 2025
Member
kirankumarkolli
left a comment
kirankumarkolli
left a comment
There was a problem hiding this comment.
Session immediate yield its only for compute team and is making the types on the Policy type internal set
Member
FabianMeiswinkel
left a comment
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
I agree with Kiran's comment - Env-variable doesn't need to (or probabyl shouldn't) allow setting ot 0 or -1 - for now let us reduce the scope to just Compute Gw.
kirankumarkolli
changed the title
dibahlfi
changed the title
kirankumarkolli
approved these changes
May 16, 2025
ananth7592
approved these changes
May 19, 2025
kirankumarkolli
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing MaxInRegionRetryCount variable internally so that if it has value of 0 or less than 0 we will not do any retry/delay and yield immediately for READ_SESSION_NOT_AVAILABLE error from the SessionTokenMismtatchInternalRetry policy.
SessionRetryEarlyYield.json