[Internal] Thin Client Integration: Adds diagnostic log info for thinclient mode.#5263
Closed
[Internal] Thin Client Integration: Adds diagnostic log info for thinclient mode.#5263
Conversation
|
|
||
| if (this.ThinclientRequestsSummary.IsValueCreated) | ||
| { | ||
| jsonWriter.WriteFieldName("ThinclientCalls"); |
Member
There was a problem hiding this comment.
Change it to ProxyCalls ?
Contributor
Author
There was a problem hiding this comment.
Let's keep thinclient across, thinclient is the mode name and summary has details about different mode names.
| PerPartitionCircuitBreaker = 2, | ||
| PerPartitionCircuitBreaker = 2, | ||
|
|
||
| ThinClient = 3, |
Member
There was a problem hiding this comment.
ThinClient in diagnostic naming feels not right. At=least syntactically ThinProxy might be right mapping.
Might be even better to have an abstract notion (like GWV2 etc...) thoughts?
Member
There was a problem hiding this comment.
Yes - ThinProxy sounds better.
Member
|
Closing this PR as the follow up PR PR-5265 has been merged with only the user agent feature changes. We can re-open this PR in the future if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Updated the Diagnostics Summary to contain the proxy interactions:
Added a new feature in the UserAgentFeatureFlags the following, so that the diagnostics user agent can contain the
thin client enablement flag:
An updated user agent can look like the following:
"User Agent": "cosmos-netstandard-sdk/3.51.0|1|X64|Microsoft Windows 10.0.26100|.NET 6.0.36|L|F4|"if only thinclient is enabled.Closing issues
To automatically close an issue: closes #4615