Skip to content

Patch: Fixes patch operations with long numeric strings in paths#5299

Closed
Copilot wants to merge 13 commits intomasterfrom
copilot/fix-5154
Closed

Patch: Fixes patch operations with long numeric strings in paths#5299
Copilot wants to merge 13 commits intomasterfrom
copilot/fix-5154

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jul 17, 2025 •
edited
Loading

  • Add PatchPathHelper to handle long numeric strings in patch paths
  • Add comprehensive test coverage
  • Add emulator test
  • Fix breaking change: Change PatchPathHelper from public to internal
  • Validate contract tests pass

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

github-actions[bot]
github-actions Bot reviewed Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@NaluTripician
Initial exploration of patch operations issue
2838a3a 
Co-authored-by: NaluTripician <27316859+NaluTripician@users.noreply.github.com>
@NaluTripician NaluTripician changed the title [WIP] Patch operations fail when path contains integer-looking part Patch operations: Fixes bug where patch operations fail when path contains integer-looking part Jul 17, 2025
Copilot AI and others added 2 commits July 17, 2025 22:23
@NaluTripician
Implement PatchPathHelper to handle long numeric strings in patch paths
2e4a92a 
Co-authored-by: NaluTripician <27316859+NaluTripician@users.noreply.github.com>
@NaluTripician
Complete implementation: handle long numeric strings in patch operati…
c1245f1 
…on paths

Co-authored-by: NaluTripician <27316859+NaluTripician@users.noreply.github.com>
Copilot AI changed the title Patch operations: Fixes bug where patch operations fail when path contains integer-looking part Fix patch operations with long numeric strings in paths Jul 17, 2025
Copilot AI requested a review from NaluTripician July 17, 2025 22:31
@NaluTripician NaluTripician changed the title Fix patch operations with long numeric strings in paths Patch: Fix patch operations with long numeric strings in paths Jul 17, 2025
@NaluTripician
Copy link
Copy Markdown
Contributor

NaluTripician commented Jul 17, 2025

@copilot please write an emulator test mirroring the code in the original issue

@NaluTripician NaluTripician changed the title Patch: Fix patch operations with long numeric strings in paths Patch: Fixes patch operations with long numeric strings in paths Jul 17, 2025
@NaluTripician
Add emulator test for long numeric strings in patch operation paths
39fd50b 
Co-authored-by: NaluTripician <27316859+NaluTripician@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jul 17, 2025

@copilot please write an emulator test mirroring the code in the original issue

Added the emulator test ItemPatchWithLongNumericStringPathTest that mirrors the original issue scenario from #5154. The test verifies patch operations with long numeric strings (20+ characters) work correctly against the Cosmos DB emulator. See commit 39fd50b.

@NaluTripician NaluTripician marked this pull request as ready for review July 31, 2025 18:59
@kundadebdatta
Copy link
Copy Markdown
Member

kundadebdatta commented Aug 5, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).

kirankumarkolli
kirankumarkolli requested changes Aug 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change

@NaluTripician
Copy link
Copy Markdown
Contributor

NaluTripician commented Oct 31, 2025

Breaking change

@copilot fix the breaking change

@NaluTripician
Fix breaking change: Change PatchPathHelper from public to internal
b3e5f17 
Co-authored-by: NaluTripician <27316859+NaluTripician@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Oct 31, 2025

Breaking change

@copilot fix the breaking change

Fixed the breaking change by changing PatchPathHelper from public to internal. The class is only used internally within the SDK and by test assemblies (which have InternalsVisibleTo access), so this change is appropriate and maintains the fix functionality. See commit b3e5f17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@NaluTripician NaluTripician Awaiting requested review from NaluTripician

@khdang khdang Awaiting requested review from khdang

@sboshra sboshra Awaiting requested review from sboshra

@adityasa adityasa Awaiting requested review from adityasa

@neildsh neildsh Awaiting requested review from neildsh

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@kirillg kirillg Awaiting requested review from kirillg

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

@NaluTripician NaluTripician

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NaluTripician @kundadebdatta @kirankumarkolli