[Internal] Thin Client Integration: Removes ThinClientStoreModel and uses GatewayStoreModel for better code modularity.#5323
Merged
kirankumarkolli merged 7 commits intomasterfrom Aug 5, 2025
Conversation
aavasthy
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aavasthy
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates thin client functionality directly into the GatewayStoreModel, removing the separate ThinClientStoreModel class for better code modularity. The change simplifies the architecture by consolidating connection mode logic within a single store model.
- Removes ThinClientStoreModel and moves its functionality into GatewayStoreModel
- Updates GatewayStoreModel to conditionally use thin client operations based on enableThinClientMode flag
- Migrates all thin client tests from ThinClientStoreModelTests to GatewayStoreModelTest
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ThinClientStoreModelTests.cs | Deleted - entire test file removed |
| GatewayStoreModelTest.cs | Added thin client test methods migrated from deleted test file |
| CosmosItemThinClientTests.cs | Updated assertions to check for " |
| ThinClientStoreModel.cs | Deleted - entire class removed |
| GlobalPartitionEndpointManagerCore.cs | Updated method calls to use GatewayStoreModel instead of ThinClientStoreModel |
| GatewayStoreModel.cs | Enhanced to support thin client mode with conditional logic |
| DocumentClient.cs | Simplified initialization to only use GatewayStoreModel for gateway mode |
| ClientRetryPolicy.cs | Updated method call to use GatewayStoreModel instead of ThinClientStoreModel |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kundadebdatta
previously approved these changes
Aug 4, 2025
Member
kundadebdatta
left a comment
kundadebdatta
left a comment
There was a problem hiding this comment.
LGTM. Approved with suggestions.
kirankumarkolli
approved these changes
Aug 4, 2025
kundadebdatta
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
It is observed that most of the working principle on the ThinClientStoreModel can be achieved by the GatewayStoreModel. Therefore, removing ThinClientStoreModel and accommodating the logic to navigate between thinclient mode and gateway mode in GatewayStoreModel. Added tests to verify correct working of all three connection modes: thinclient, gateway and direct.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5311