[Internal] Feed Range: Fixes 6 AOT violations from FeedRangeInternalConverter, CosmosExceptionFactory and CosmosHttpClientCore#5336
Merged
kirankumarkolli merged 4 commits intomsdata/aotfrom Aug 6, 2025
Conversation
kundadebdatta
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
| IWebProxy webProxy, | ||
| Func<X509Certificate2, X509Chain, SslPolicyErrors, bool> serverCertificateCustomValidationCallback) | ||
| { | ||
| // TODO: Remove Reflection when multitargetting is possible |
Member
There was a problem hiding this comment.
How about having two separate implementations in two helpers methods and use pre-processor to select one? Will help port changes between?
Member
Author
There was a problem hiding this comment.
Yes - make sense. Let me quickly refactor.
kirankumarkolli
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
FeedRangeInternalConverter,CosmosExceptionFactoryandCosmosHttpClientCoreType of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber