Skip to content

[Internal] Msdata/Direct: Adds support for Nregion synchronous commit #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ananth7592 wants to merge 4 commits into from
Closed

[Internal] Msdata/Direct: Adds support for Nregion synchronous commit #5375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fd0ef5
Adds support for including nregioncommit account feature while creati…
ananth7592 Aug 7, 2025
bdc7f9c
NRegion barrier writes support for < Strong consistency
ananth7592 Aug 11, 2025
8745aee
Emulator test for NregionCommit Write Barrier
ananth7592 Sep 3, 2025
06a83b1
* Barrier Request helper doesn't need NregionLSN
ananth7592 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Microsoft.Azure.Cosmos/src/DocumentClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6797,7 +6797,12 @@ private void InitializeDirectConnectivity(IStoreClientFactory storeClientFactory
}

private void CreateStoreModel(bool subscribeRntbdStatus)
{
{
AccountProperties accountProperties = this.accountServiceConfiguration.AccountProperties;

bool enableNRegionSynchronousCommit = accountProperties.EnableNRegionSynchronousCommit;
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be more than a boolean flag (instead an absolute number of regions that must have committed)?

AccountConfigurationProperties accountConfigurationProperties = new (EnableNRegionSynchronousCommit: enableNRegionSynchronousCommit);

//EnableReadRequestsFallback, if not explicity set on the connection policy,
//is false if the account's consistency is bounded staleness,
//and true otherwise.
Expand All @@ -6812,7 +6817,8 @@ private void CreateStoreModel(bool subscribeRntbdStatus)
this.UseMultipleWriteLocations && (this.accountServiceConfiguration.DefaultConsistencyLevel != Documents.ConsistencyLevel.Strong),
true,
enableReplicaValidation: this.isReplicaAddressValidationEnabled,
sessionRetryOptions: this.ConnectionPolicy.SessionRetryOptions);
sessionRetryOptions: this.ConnectionPolicy.SessionRetryOptions,
accountConfigurationProperties: accountConfigurationProperties);

if (subscribeRntbdStatus)
{
Expand Down
22 changes: 22 additions & 0 deletions Microsoft.Azure.Cosmos/src/RMResources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions Microsoft.Azure.Cosmos/src/RMResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,9 @@
<data name="GlobalStrongWriteBarrierNotMet" xml:space="preserve">
<value>Global Strong write barrier has not been met for the request.</value>
</data>
<data name="NRegionCommitWriteBarrierNotMet" xml:space="preserve">
<value>NRegion Commit write barrier has not been met for the request.</value>
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint about how apps can deal with it? Should they retry? Is it useless?

</data>
<data name="BadClientMongo" xml:space="preserve">
<value>At this time, only write operations made from the MongoDB SDKs are supported. Modifications to MongoDB collections using other SDKs is temporarily blocked.</value>
</data>
Expand Down Expand Up @@ -1307,6 +1310,9 @@ If you would like to serve this query through continuation tokens, then please r
<data name="Server_GlobalStrongWriteBarrierNotMet" xml:space="preserve">
<value>Service is currently unavailable. More info: https://aka.ms/cosmosdb-tsg-service-unavailable. Could not achieve backend quorum for Strong or Bounded Staleness after barrier requests.</value>
</data>
<data name="Server_NRegionCommitWriteBarrierNotMet" xml:space="preserve">
<value>Service is currently unavailable. More info: https://aka.ms/cosmosdb-tsg-service-unavailable. N-Region Commit write barrier has not been met for the request.</value>
</data>
<data name="Server_NameCacheIsStaleExceededRetryLimit" xml:space="preserve">
<value>Service is currently unavailable. More info: https://aka.ms/cosmosdb-tsg-service-unavailable. Container was re-created, exceeded retries to resolve new identifier. Please contact support with the full exception.</value>
</data>
Expand Down
2 changes: 2 additions & 0 deletions Microsoft.Azure.Cosmos/src/Resource/Settings/AccountProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,5 +269,7 @@ private IDictionary<string, object> QueryStringToDictConverter()
[JsonExtensionData]
internal IDictionary<string, JToken> AdditionalProperties { get; set; }

[JsonProperty(PropertyName = Constants.Properties.EnableNRegionSynchronousCommit, NullValueHandling = NullValueHandling.Ignore)]
internal bool EnableNRegionSynchronousCommit { get; set; }
}
}
Loading