Add annotations and suppressions for safe EventSource usage#5389
Merged
ananth7592 merged 1 commit intoAzure:msdata/aotfrom Sep 10, 2025
Merged
Add annotations and suppressions for safe EventSource usage#5389ananth7592 merged 1 commit intoAzure:msdata/aotfrom
ananth7592 merged 1 commit intoAzure:msdata/aotfrom
Conversation
agocke
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
anuchandy
reviewed
Sep 9, 2025
Member
anuchandy
left a comment
anuchandy
left a comment
There was a problem hiding this comment.
@agocke thank you! can we please re-target the pr to msdata/aot branch from master? AOT cosmos ship from msdata/aot branch
agocke
requested review from
a team,
adityasa,
khdang,
kirillg,
leminh98 and
neildsh
as code owners
Same idea as Azure#5388, but this provides appropriate attributes to mark the use as safe. The long-term goal here should be to add a net8 target to validate that this is correct.
agocke
force-pushed
the
annotate-eventsource
branch
from
a813588 to
153a92c
Compare
Author
|
done |
anuchandy
approved these changes
Sep 10, 2025
ananth7592
added a commit
that referenced
this pull request
Sep 10, 2025
- Contains changes for Add annotations and suppressions for safe EventSource usage (#5389)
ananth7592
added a commit
that referenced
this pull request
Sep 10, 2025
- Contains changes for Add annotations and suppressions for safe EventSource usage (#5389)
ananth7592
added a commit
that referenced
this pull request
Sep 10, 2025
## Description - Contains changes for Add annotations and suppressions for safe EventSource usage (#5389) - ## Type of change Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue) - [] New feature (non-breaking change which adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [] This change requires a documentation update ## Closing issues To automatically close an issue: closes #IssueNumber
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same idea as #5388, but this provides appropriate attributes to mark the use as safe.
The long-term goal here should be to add a net8 target to validate that this is correct.