Fixes race condition that can cause InvalidOperationException in CosmosOperationCancelledException.ToString()#5421
Closed
FabianMeiswinkel wants to merge 33 commits intomasterfrom
Closed
Fixes race condition that can cause InvalidOperationException in CosmosOperationCancelledException.ToString()#5421FabianMeiswinkel wants to merge 33 commits intomasterfrom
FabianMeiswinkel wants to merge 33 commits intomasterfrom
Conversation
…concurrent access Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
…tion points Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
…tions Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
Since isBeingWalked flag prevents modifications during enumeration, snapshot methods are no longer needed. The trace system now uses direct enumeration with walking state protection instead of creating copies. Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
…mosTraceDiagnostics Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
…move parameter Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
… adjust assignment order Co-authored-by: kirankumarkolli <6880899+kirankumarkolli@users.noreply.github.com>
…as started - but instead just operate on cloned snapshots
FabianMeiswinkel
requested review from
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixes race condition that can cause InvalidOperationException in CosmosOperationCancelledException.ToString() - especially when cross-regional hedging is enabled and E2E timeouts happen (CancellationToken being cancelled).
Type of change
Please delete options that are not relevant.
Closing issues
ICM#66334029
To automatically close an issue: closes #IssueNumber