[Thin Client Integration]: Adds thinclient header for refresh account data requests. #5535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aavasthy
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aavasthy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In ThinClient mode when endpoint refresh happens or request encounters a HttpRequestException , the ClientRetryPolicy triggers a location refresh by calling GlobalEndpointManager.RefreshLocationAsync(). This refresh fetches updated account information from the service. However, the refresh request was missing the thinclient endpoint discovery header (x-ms-cosmos-thinclient-endpoint-discovery).
Without this header, the service returned standard endpoint information instead of thin client-specific endpoint information. Due to this after a failover or endpoint refresh, the SDK was not receiving the correct thin client endpoints.
As part of this PR added thinclient header with refresh request for get database account info.
Tested this change for region failover scenario and tested it for endpoint manager refresh scenario.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5536