Skip to content

[WIP] Address feedback on ObjectDisposedException handling in CosmosClient#5599

Closed
Copilot wants to merge 1 commit intousers/kirankk/copilot-5596-fix-storeproxy-disposedfrom
copilot/sub-pr-5597
Closed

[WIP] Address feedback on ObjectDisposedException handling in CosmosClient#5599
Copilot wants to merge 1 commit intousers/kirankk/copilot-5596-fix-storeproxy-disposedfrom
copilot/sub-pr-5597

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 2, 2026

Thanks for the feedback on #5597. I've created this new PR, which merges into #5597, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #5597
Triggering review: #5597 (comment)

@copilot please double check the order of setting isDisposed to True and setting the mutable fields to null in Dispose


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@FabianMeiswinkel
Copy link
Copy Markdown
Member

@copilot there were no changes yet - are you still working on this PR?

@FabianMeiswinkel
Copy link
Copy Markdown
Member

Fixed already

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants