-
Notifications
You must be signed in to change notification settings - Fork 533
Read Consistency Strategy: Adds hub region header for LastCommittedWriteRegion strategy. #5815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aavasthy
wants to merge
7
commits into
main
Choose a base branch
from
users/aavasthy/ReadConsistencyWithHubRegionheader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b5e72b2
Add hub region header for read consistency strategy
aavasthy 57e2e02
Only setting hub region header for LastCommittedWriteRegion ReadConsi…
aavasthy cddf8f1
Merge branch 'master' into users/aavasthy/ReadConsistencyWithHubRegio…
aavasthy b009087
Update tests
aavasthy a24b765
merge with master
aavasthy 8db9406
Merge branch 'master' into users/aavasthy/ReadConsistencyWithHubRegio…
aavasthy 5bcbbaa
Update contracts and fix tests
aavasthy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Recommendation — Design: Consider interaction with
CrossRegionHedgingAvailabilityStrategyWhen
CrossRegionHedgingAvailabilityStrategyandLastCommittedWriteRegionare both active, the hedging strategy clones the request (including theShouldProcessOnlyInHubRegionheader) and sends copies to multiple regions in parallel. Non-hub regions will return 403/3, whichIsFinalResult()does NOT treat as final — so each hedged copy retries internally, generating cascading 403/3 traffic.Concrete scenario: 3-region account with hedging enabled +
LastCommittedWriteRegionread → 3 parallel requests → 2 get 403/3 and retry → generates ~5+ backend requests for one logical read, with wasted RUs and added latency.Why it matters: The combination is semantically contradictory — hedging spreads across regions, but hub-only routing rejects all non-hub regions. This isn't a correctness bug (it eventually converges), but it's wasteful and could confuse diagnostics.
Suggestion: Either:
ShouldHedgeto skip hedging whenShouldProcessOnlyInHubRegionis set, or