Add value-based equality for CosmosClientOptions and other option bags#5901
Open
AndriySvyryd wants to merge 1 commit into
Open
Add value-based equality for CosmosClientOptions and other option bags#5901AndriySvyryd wants to merge 1 commit into
AndriySvyryd wants to merge 1 commit into
Conversation
AndriySvyryd
force-pushed
the
Issue4965
branch
2 times, most recently
from
865e63f to
262c71b
Compare
Implements IEquatable on CosmosClientOptions, CosmosClientTelemetryOptions, CosmosThresholdOptions, and CosmosSerializationOptions. Equality compares only publicly settable properties (including PREVIEW-gated public setters); properties without a public setter are excluded. Reference-type properties (delegates, factories, custom callbacks) use reference equality, matching the rest of the SDK conventions. Closes Azure#4965
AndriySvyryd
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
jeet1995,
khdang,
kirankumarkolli,
kundadebdatta,
kushagraThapar,
neildsh,
sboshra and
xinlian12
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements IEquatable on CosmosClientOptions, CosmosClientTelemetryOptions, CosmosThresholdOptions, and CosmosSerializationOptions. Equality compares only publicly settable properties (including PREVIEW-gated public setters); internal-only state and properties without a public setter are excluded. Reference-type properties (delegates, factories, custom callbacks) use reference equality, matching the rest of the SDK conventions.
Closes #4965.