[Internal] Thin Client Integration: Fixes Exclude regions check for thinclient mode.#5928
Open
aavasthy wants to merge 2 commits into
Open
[Internal] Thin Client Integration: Fixes Exclude regions check for thinclient mode.#5928aavasthy wants to merge 2 commits into
aavasthy wants to merge 2 commits into
Conversation
Member
kushagraThapar
left a comment
There was a problem hiding this comment.
Thanks @aavasthy, overall looks good, it would be good to have some more testing on all regions excluded code path and end to end hedging tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This change resolves an issue where per-request region exclusions were not honored when the SDK operated in thin client mode. Previously, requests configured with ExcludeRegions would still route to theprimary thin client endpoint regardless of the customer's regional preferences, preventing them from steering traffic away from specific regions during operational events. With this fix, thin client requestrouting now filters available endpoints against the excluded region list in a manner consistent with the standard gateway path, restoring expected behavior for both individual operations and cross-region hedging scenarios. The change is scoped narrowly to the thin client resolution path, preserves all existing routing semantics when no exclusions are specified, and is covered by new unit and integration test.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5789
Changelog
### Unreleasedinchangelog.mdfor the user-facing impact of this change.
If the second box is checked, briefly justify here: