Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the infra/core modules to AVM modules #3976

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Update the infra/core modules to AVM modules #3976

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
953f948
Convert infra/core to AVM
Menghua1 Jun 4, 2024
a66ba8a
Add the modification of repo.yaml
Menghua1 Jun 4, 2024
a6034f5
Modify parameter description, spaces, etc.
Menghua1 Jun 4, 2024
3163c23
Standard parameter naming
Menghua1 Jun 6, 2024
b3a89a8
modify models.py
Menghua1 Jun 19, 2024
50473a4
fix pr2016 and pr2103
Menghua1 Jun 21, 2024
4b2f44a
update apim service toavm module
Menghua1 Jun 24, 2024
00648d5
Add useAPIM conditional judgment
Menghua1 Jun 24, 2024
cef4144
update web site config to avm
Menghua1 Jul 5, 2024
ffa27d9
add api tags
Menghua1 Jul 5, 2024
93de7e6
update keyvault sku
Menghua1 Jul 9, 2024
9f95b92
disable purge protection
Menghua1 Jul 9, 2024
b3fd198
disable purge protection
Menghua1 Jul 9, 2024
a6a3010
Merge remote-tracking branch 'origin/main' into avmupdates
Menghua1 Jul 10, 2024
9b54ddd
Merge remote-tracking branch 'origin/main' into avmupdates
Menghua1 Aug 23, 2024
868ab2e
Add Infra/app files
Menghua1 Sep 2, 2024
7ad17e8
modify parameters
Menghua1 Sep 2, 2024
26963c9
Modify api-avm parameters
Menghua1 Sep 3, 2024
56d33e9
update apimapi to use ptn module
Menghua1 Sep 29, 2024
8f34f52
Merge branch 'main' into avmupdates
Menghua1 Sep 29, 2024
3399e7f
update db to infra/app
Menghua1 Sep 29, 2024
bab182b
Merge branch 'main' into avmupdates
Menghua1 Oct 9, 2024
17f0961
Update apim parameter, cosmos-sql
Menghua1 Oct 9, 2024
93947a2
Update cosmos-mongo module name
Menghua1 Oct 9, 2024
fd8a899
delete the redundant parameter connectionStringKey
Menghua1 Oct 11, 2024
52ddfbe
add monitor ptn module
Menghua1 Oct 12, 2024
def0102
Merge branch 'main' into avmupdates
Menghua1 Oct 15, 2024
1f7da17
add container pth module
Menghua1 Oct 15, 2024
f1077a7
update cosmos-mongo-db-avm output
Menghua1 Oct 22, 2024
828f2a6
update aks and aca to avm
Menghua1 Oct 28, 2024
8910cac
Update appservice with App Insights env var
Menghua1 Oct 28, 2024
260ac1c
Merge branch 'main' into avmupdates
Menghua1 Oct 28, 2024
7eff057
Update module name
Menghua1 Oct 28, 2024
5406a10
Update module container-app-upsert version
Menghua1 Oct 29, 2024
b8ff872
Merge branch 'main' into avmupdates
Menghua1 Nov 20, 2024
257f48a
update nodeResourceGroupName parameter
Menghua1 Nov 20, 2024
5a6a96f
Merge remote-tracking branch 'origin' into avmupdates
Menghua1 Jan 8, 2025
722cad9
update aks
Menghua1 Jan 8, 2025
e82800b
Remove redundant parameters
Menghua1 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions templates/todo/api/python/todo/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ def __init__(self, *args, **kwargs):
AZURE_KEY_VAULT_ENDPOINT: Optional[str] = None
APPLICATIONINSIGHTS_CONNECTION_STRING: Optional[str] = None
APPLICATIONINSIGHTS_ROLENAME: Optional[str] = "API"
PRIMARY_WRITE_KEY: str = ""
PRIMARY_READONLY_KEY: str = ""
SECONDARY_WRITE_CONNECTION_STRING: str = ""
PRIMARY_READONLY_CONNECTION_STRING: str = ""
SECONDARY_WRITE_KEY: str = ""
SECONDARY_READONLY_KEY: str = ""
SECONDARY_READONLY_CONNECTION_STRING: str = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the bicep, so not sure why we need these new variables....

Copy link
Member Author

@Menghua1 Menghua1 Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbreza Because when creating Cosmos Mongo with AVM before, multiple secrets will be created by default. If these new variables are not defined, the deployment of the API will fail. For more details, please see the comment #3976 (comment) and #3976 (comment).
Now the code of avm/res/document-db/database-account has been updated, and multiple secrets will not be created by default. We will also update our code.


class Config:
env_file = ".env"
Expand Down
Loading
Loading