Add an optional parameter to the key vault resource to send audit logs to the log analytics workspace #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
requested review from
jongio,
wbreza,
ellismg,
vhvb1989,
hemarina and
weikanglim
as code owners
jongio
reviewed
Jul 5, 2024
| @@ -3,8 +3,12 @@ param name string | |||
| param location string = resourceGroup().location | |||
| param tags object = {} | |||
|
|
|||
| @description('The ID of the principal to grant access to the key vault.') | |||
There was a problem hiding this comment.
Please add these changes to AVM if needed. We are deprecating infra/core.
|
Hi @tonybaloney. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Well Architected Framework specifies that key vault resources should send audit logs to a log analytics workspace.
This change adds the parameter and if specified configures the audit logs to a log analytics workspace ID.
I've updated the existing templates in this repository to use it, since they're already provisioning a log analytics workspace.
See https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.KeyVault.Logs/