azd env set add warning
#4547
azd env set add warning
#4547
Conversation
NanaXiong00
requested review from
ellismg,
wbreza,
vhvb1989,
hemarina and
weikanglim
as code owners
cli/azd/cmd/env.go
Outdated
| conflictKeysStr := strings.Join(conflictKeys, " and ") | ||
| fmt.Print( | ||
| output.WithWarningFormat( | ||
| "WARNING: The environment variable %s already exists in the .env file with a different case.\n", |
There was a problem hiding this comment.
Let's hold off on merging, I'd like to continue with the requirements discussion here before we finalize the changes.
There was a problem hiding this comment.
@vhvb1989 pushed a change, does this look good to you?
There was a problem hiding this comment.
Maybe just me but the word "instead" is throwing me off a bit since it's printing the same name used in the original command. I think it makes more sense to either omit "instead" or change the phrasing to "Did you mean to set 'foo' instead":
Any thoughts?
There was a problem hiding this comment.
It definitely should be reworded as did you mean to set 'foo' instead?
@vhvb1989 The multiple insensitive cases is still a weird situation :D it almost clearly signals user intention of wanting to set multiple different casings. Still feels as-if the confirmation would be a better approach
or we can just stop printing warning messages for n>1
microsoft-github-policy-service
bot
added
the
no-recent-activity
|
Hi @NanaXiong00. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Fixes issue #289.
azd env setadds warning about case sensitivity: warn if the same value is present but in mixed case.As shown in the figure below:
@rajeshkamal5050 for notification.