Add schema support for cosmos db #4780
Open
+185
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
karolz-ms,
wbreza,
vhvb1989,
hemarina,
weikanglim and
JeffreyCA
as code owners
weikanglim
reviewed
Feb 13, 2025
| @@ -407,6 +457,12 @@ module {{bicepName .Name}} 'br/public:avm/res/app/container-app:0.8.0' = { | |||
| secretRef: 'mongodb-url' | |||
| } | |||
| {{- end}} | |||
| {{- if .DbCosmos}} | |||
| { | |||
| name: 'AZURE_COSMOSDB_ENDPOINT' | |||
There was a problem hiding this comment.
Does AZURE_COSMOS_ENDPOINT seem any better here?
There was a problem hiding this comment.
Yes, AZURE_COSMOS_ENDPOINT is better.
cli/azd/pkg/project/resources.go
Outdated
Comment on lines
211
to
212
| ContainerName string `yaml:"containerName,omitempty"` | ||
| PartitionKeyPaths []string `yaml:"partitionKeyPaths,omitempty"` |
There was a problem hiding this comment.
Does Name and PartitionKeys sound any better?
weikanglim
reviewed
Feb 14, 2025
cli/azd/pkg/project/resources.go
Outdated
Comment on lines
211
to
212
| Name string `yaml:"containerName,omitempty"` | ||
| PartitionKeys []string `yaml:"partitionKeyPaths,omitempty"` |
There was a problem hiding this comment.
In the YAML schema, does name and partitionKeys feel nicer?
weikanglim
reviewed
Feb 15, 2025
Comment on lines
+126
to
+137
| containers: [ | ||
| {{- range .DbCosmos.Containers}} | ||
| { | ||
| name: '{{ .ContainerName }}' | ||
| paths: [ | ||
| {{- range $path := .PartitionKeyPaths}} | ||
| '{{ $path }}' | ||
| {{- end}} | ||
| ] | ||
| } | ||
| {{- end}} | ||
| ] |
There was a problem hiding this comment.
I've had time to look into this more, and I'm wondering if we should not specify any container properties. For non-Java languages, this is usually created as a dataplane operation within the SDK clients.
I think there's a similar concept in Azure Spring Cloud for CosmosDB, where the annotation would create the container on boot time. Would you be able to confirm and see if we can avoid adding this entirely?
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
weikanglim
reviewed
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #4671, this PR will add the resource support of Azure Cosmos DB.