Skip to content

Reduce Fig spec size by pruning help and output noise #8417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeffreyCA wants to merge 3 commits into
base: main
Choose a base branch
from
+370 −1,517
Open

Reduce Fig spec size by pruning help and output noise #8417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d5f424
Reduce Fig spec size by pruning help and output noise
JeffreyCA May 29, 2026
a139ed7
Add more tests
JeffreyCA May 30, 2026
1bb48cd
Add more tests
JeffreyCA May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cli/azd/cmd/completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,20 @@ func newCompletionPowerShellAction(cmd *cobra.Command) actions.Action {

// Fig completion action and flags
type completionFigFlags struct {
includeHidden bool
includeHidden bool
includeHelpSubcommands bool
}

func newCompletionFigFlags(cmd *cobra.Command) *completionFigFlags {
flags := &completionFigFlags{}
cmd.Flags().BoolVar(&flags.includeHidden, "include-hidden", false, "Include hidden commands in the Fig spec")
_ = cmd.Flags().MarkHidden("include-hidden")
cmd.Flags().BoolVar(
&flags.includeHelpSubcommands,
"include-help-subcommands",
false,
"Include subcommands under the help command in the Fig spec",
)
return flags
}

Expand Down Expand Up @@ -191,6 +198,7 @@ func (a *completionFigAction) Run(ctx context.Context) (*actions.ActionResult, e

// Generate the Fig spec
builder := figspec.NewSpecBuilder(a.flags.includeHidden).
WithHelpSubcommands(a.flags.includeHelpSubcommands).
WithExtensionMetadata(a.extensionManager)
spec := builder.BuildSpec(rootCmd)

Expand Down
3 changes: 3 additions & 0 deletions cli/azd/cmd/completion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,13 @@ func TestCompletionFigFlags(t *testing.T) {

require.NotNil(t, flags)
require.False(t, flags.includeHidden)
require.False(t, flags.includeHelpSubcommands)

// Verify flag is registered
f := cmd.Flags().Lookup("include-hidden")
require.NotNil(t, f)
f = cmd.Flags().Lookup("include-help-subcommands")
require.NotNil(t, f)
}

func TestCompletionHelpDescriptions(t *testing.T) {
Expand Down
Loading
Loading