Skip to content

Update CI build names to include timestamp and build rev # #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented May 21, 2025

Update CI build names to include timestamp and build rev #

Also fixed the git url in the npm package json

@liliankasem liliankasem requested a review from a team as a code owner May 21, 2025 22:58
@jviau
Copy link
Contributor

jviau commented May 22, 2025

Not sure if you want to port the MSBuild targets I have in the host and other repos we own. Those targets will set the build name for you.

@liliankasem
Copy link
Member Author

liliankasem commented May 22, 2025

Not sure if you want to port the MSBuild targets I have in the host and other repos we own. Those targets will set the build name for you.

Yeah I do want to bring those in at some point. I also really want to include the version in the name e.g.

4.0.7030-20250522.1

The other thing I am questioning is the versioning mechanism here, it's automated and different for every CI run. We end up with in-proc being a different version to out of proc e.g.:

// default version
Core Tools Version:       4.0.7030 Commit hash: N/A +bb4c949899cd5659d6bfe8b92cc923453a2e8f88 (64-bit)
Function Runtime Version: 4.1037.0.23568

// version for running inproc host
Core Tools Version:       4.0.7032 Commit hash: N/A +ec5981453def131abe6005327168b918fac8d426 (64-bit)
Function Runtime Version: 4.634.3.22875

And I am not sure that these need to be different. Would love to brainstorm some ideas with you both on how we can make versioning make sense, and easily coordinate between the many different pipelines we run (core /main; core /in-proc; host; consolidated; linux build etc.)

@aishwaryabh @jviau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants