-
Notifications
You must be signed in to change notification settings - Fork 453
Update version tests to use the new test framework #4443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…work Co-authored-by: aishwaryabh <[email protected]>
Can you take all the tests in VersionTests and update all of the tests to be using the new framework? Delete the old VersionTests file and create files and organize the tests like done over here: https://github.com/Azure/azure-functions-core-tools/tree/main/test/Cli/Func.E2E.Tests/Commands |
Co-authored-by: aishwaryabh <[email protected]>
Done! I've restructured all the version tests according to the new framework pattern. Changes made:
The structure now matches the pattern used in other E2E command tests. Commit: 7615990 Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR updates the
func --version
tests to use the new testing framework, as requested in issue #4337.Changes Made
FuncVersionCommand
class intest/Cli/TestFramework/Commands/
directory that extends the baseFuncCommand
class to handle version-related command executionVersionTests
class to use the new command-based testing approach instead of the olderCliTester.Run
methodversion
toVersion_DisplaysVersionNumber
to better follow naming conventionsIsRunningAnOlderVersion
since they are focused on testing the internal version comparison logic rather than CLI commandsImplementation Details
The original test was running the CLI and checking for version output containing "4.". The new implementation:
FuncVersionCommand
to execute the version commandThe two unit tests that verify version comparison functionality (
IsRunningAnOlderVersion_ShouldReturnTrue_WhenVersionIsOlder
andIsRunningAnOlderVersion_ShouldReturnFalse_WhenVersionIsUpToDate
) were kept as-is since they're not testing CLI functionality directly.Fixes #4337.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
azfunc.pkgs.visualstudio.com
dotnet build test/Azure.Functions.Cli.Tests/Azure.Functions.Cli.Tests.csproj
(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js
(dns block)dotnet build test/Cli/TestFramework/Azure.Functions.Cli.TestFramework.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.