Skip to content

[WIP] Update deployment tests to use new test framework #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented May 27, 2025

  • Analyze original DeploymentTests.cs and new test framework structure
  • Create FuncDeployCommand class for the new test framework
  • Create new DeploymentTests class using the new test framework
    • Port over Azure resource initialization logic
    • Rewrite RemoteBuildPythonFunctionApp test to use the new test pattern
    • Implement proper logging and process handling
  • Add appropriate traits and configurations for CI integration
  • Test implementation by running the test
  • Clean up any remaining issues

Fixes #4331.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@aishwaryabh
Copy link
Contributor

can you try again? specifically use the instructions in this README as well to create these tests: https://github.com/Azure/azure-functions-core-tools/blob/main/test/Cli/Func.E2E.Tests/README.md

I also want you to use this as a reference for the older test framework, in terms of the tests you actually need to transfer

Copy link
Contributor Author

Copilot AI commented May 30, 2025

can you try again? specifically use the instructions in this README as well to create these tests: https://github.com/Azure/azure-functions-core-tools/blob/main/test/Cli/Func.E2E.Tests/README.md

I ...

I've created the deployment tests using the new E2E test framework following the README instructions. The implementation includes:

  • FuncDeployCommand class following the pattern from other command classes
  • DeploymentTests class that inherits from BaseE2ETests
  • Ported the RemoteBuildPythonFunctionApp test with proper environment variable checks
  • Used appropriate traits (WorkerRuntime=Python, Group=Deploy) for CI integration
  • Applied FluentAssertions and proper test patterns from the new framework

The test structure is ready and follows the new patterns. Azure resource management still needs to be implemented in the new framework (marked with TODOs), but the test foundation is solid.

Commit: 6e343a9

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • azfunc.pkgs.visualstudio.com
    • Triggering command: dotnet build test/Cli/Func.E2E.Tests (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of aishwaryabh May 30, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deployment tests to use new test framework
2 participants