Wrap every command in a retry helper to improve test runs in CI #4453
+308
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishwaryabh
changed the title
|
Why do they need to be wrapped in a retry? After how many retries are these tests passing? I think this points to an underlying issue we should investigate - it shouldn't be flaky to this extend no? |
|
Not sure if you have looked into Polly: https://github.com/App-vNext/Polly -- it is a great library for building retry pipelines. But also agree with @liliankasem about understanding the underlying reason these tests are flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
#4458
This PR wraps every command in the E2E test framework in a retry helper to improve test runs in CI.
Pull request checklist